Re: [netcdf-java] Small bug in HttpClientManager

• To: Jon Blower <jdb@xxxxxxxxxxxxxxxxxxxx>
• Subject: Re: [netcdf-java] Small bug in HttpClientManager
• From: John Caron <caron@xxxxxxxxxxxxxxxx>
• Date: Mon, 17 Dec 2007 09:39:29 -0800

thnkas for the heads up. what OS and JVM do you see this problem on?

Jon Blower wrote:

Hi all (particularly John C),

I've spotted a small bug in HttpClientManager in the section below:

    // nick.bower@xxxxxxxxxxxxxxxxxxxxx
    String proxyHost = System.getProperty("http.proxyHost");
    String proxyPort = System.getProperty("http.proxyPort");
    if ((proxyHost != null) && (proxyPort != null)) {
        _client.getHostConfiguration().setProxy(proxyHost,
Integer.parseInt(proxyPort));
    }

The problem here is that if the "http.proxyPort" property is set to
the empty string, the call to Integer.parseInt() fails and the class
doesn't get initialized.  (For some reason http.proxyPort is set to ""
on my system instead of null - don't know why, I'm not doing this
consciously.)

I suggest changing the if clause to:

    if ((proxyHost != null) && (proxyPort != null) &&
!proxyPort.trim().equals("")) {

Cheers, Jon

• Follow-Ups:
  • Re: [netcdf-java] Small bug in HttpClientManager
    • From: Jon Blower

• References:
  • [netcdf-java] Small bug in HttpClientManager
    • From: Jon Blower