Re: [idvdevelopers] Problem with shapefile (ESRI .shp) code in IDV

• To: idvdevelopers@xxxxxxxxxxxxxxxx
• Subject: Re: [idvdevelopers] Problem with shapefile (ESRI .shp) code in IDV
• From: Tommy Jasmin <tommy.jasmin@xxxxxxxxxxxxx>
• Date: Fri, 23 May 2014 15:52:25 -0500

On 5/23/14, 2:31 PM, Yuan Ho wrote:

On 5/23/2014 12:23 PM, Tommy Jasmin wrote:

Folks - someone here found a problem with the shapefile control and data
source code.
I have test files and have coded what I believe is a fix, but would like
to discuss with
someone before moving ahead and creating a pull request.  Who would be
the best
person to describe the details of the issue with?

Tommy,

 You can send your description to this list.

Yuan

Thanks Yuan, here goes...

year and which is from this year).

Unzip these in an old and new directory.  Both validate fine and come up
fine in any GIS program.  In IDV, with the new file, it loads but you get no
filters or table in the Layer Controls.  Old file works fine.

It looks like ShapeFileDataSource builds up the vector polygons as a
SampledSet array.  Then, and this is the part I don't understand, the
attributes from the .dbf file are ONLY LOADED if the very first element
is an instance of MapSet:

    private void setProperties(Data shapefileData, DbaseFile dbFile) {
        if ((dbFile == null) || (shapefileData == null)
                || !(shapefileData instanceof UnionSet)) {
            return;
        }
        SampledSet[] sets = ((UnionSet) shapefileData).getSets();
        // TJJ Look here: why does first element need to be MapSet ??
        if ((sets.length == 0) || !(sets[0] instanceof MapSet)) {
            return;
        }
        ...otherwise drops through and loads the properties as usual
    }

In the old file, the first entry happens to be a MapSet and everything is
fine:

MapSet:

        boolean noMapSets = true;
        for (int idx = 0; idx < sets.length; idx++) {

            if (sets[idx] instanceof MapSet) {
                noMapSets = false;
                break;
            }
        }

        if (noMapSets) return;

...everything works great.

index of the first and use that to pass properties to the Filter).

the new file having 14 polygons instead of 12:

tommyj@ubuntu:~/SHP/4-17$ shpdump DO_Merge_Clip.shp | more
Shapefile Type: Polygon   # of Shapes: 12

File Bounds: (-6075469.880,-1110460.719,0,0)
         to  (  766161.497, 1506760.778,0,0)


tommyj@ubuntu:~/SHP/5-15$ shpdump DO_Merge_Clip.shp | more
Shapefile Type: Polygon   # of Shapes: 14

File Bounds: (-6075622.353,-1294963.859,0,0)
         to  (  824461.673, 1501564.819,0,0)


--
Tommy Jasmin
Space Science and Engineering Center
University of Wisconsin, Madison
1225 West Dayton Street, Madison, WI 53706

Attachment: sdo_polygons_20140417.zip
Description: Zip archive

Attachment: sdo_polygons_20140515.zip
Description: Zip archive

• References:
  • [idvdevelopers] Problem with shapefile (ESRI .shp) code in IDV
    • From: Tommy Jasmin
  • Re: [idvdevelopers] Problem with shapefile (ESRI .shp) code in IDV
    • From: Yuan Ho