[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[netCDF #HVY-215335]: Re: [petsc-maint] Error building netcdf



Hi Satish,

Yes, thanks for reporting the problem.  The fix you've provided works, and has
also been committed to the latest development version on GitHub:

   
https://github.com/Unidata/netcdf-c/commit/508ee74874e3ac438c63f5d1cefd736353ce96c2

--Russ

> We are seeing a problem with installing netcdf on OSX with latest xcode.
> 
> >>>>>>>
> In file included from load.c:14:
> ./genlib.h:84:15: error: expected parameter declarator
> extern size_t strlcat(char *dst, const char *src, size_t siz);
> ^
> <<<<<
> 
> It appears genlib.h uses '#ifndef HAVE_STRLCAT' but does not include
> config.h where HAVE_STRLCAT would be defined. And I see the issue with
> the latest netcdf code aswell.
> 
> The following patch appears to fix the issue.
> 
> >>>>>>>>>>
> diff -r eb06a3589e77 ncgen3/genlib.h
> --- a/ncgen3/genlib.h   Wed Oct 30 19:17:10 2013 -0500
> +++ b/ncgen3/genlib.h   Wed Oct 30 19:24:06 2013 -0500
> @@ -7,7 +7,7 @@
> *********************************************************************/
> #include <stdlib.h>
> #include <limits.h>
> -
> +#include <config.h>
> extern const char *progname;   /* for error messages */
> extern const char *cdlname;    /* for error messages */
> 
> <<<<<<<<<<
> 
> Attaching the build log for netcdf [extracted from petsc's configure.log - 
> hence the
> formatting of stdout/stderr is a bit skewed] as a reference.
> 
> thanks,
> Satish
> 
> On Thu, 31 Oct 2013, Blaise A Bourdin wrote:
> 
> > Hi,
> >
> > It does fix the issue. The same bug was present in older versions, but for 
> > some reason did not pop up in my builds until recently.
> >
> > Thanks,
> >
> > Blaise
> >
> > On Oct 30, 2013, at 6:56 PM, Satish Balay <address@hidden> wrote:
> >
> > > Blaise,
> > >
> > > Does adding '#include <config.h>' fix the problem for you? If so - I'll 
> > > report it
> > > to netcdf folks.
> > >
> > > Barry,
> > >
> > > We don't currently have a git repo for netcdf patches. We are using
> > > tarball directly from netcdf folks.
> > >
> > > We are currently using version 4.2.1.1 - and the latest appears to be 
> > > 4.3.0 [but
> > > this version also appears to have the same issue]
> > >
> > > I can create a git repo with this patch [if it works for Blaise]
> > >
> > > Satish
> 
> > >> On Oct 30, 2013, at 12:29 PM, Blaise A Bourdin <address@hidden> wrote:
> > >>
> > >>> Hi,
> > >>>
> > >>> I am trying to build the latest pets-dev with netcdf and exodusII 
> > >>> support on my mac, but building netcdf fails when using gcc / gfortran 
> > >>> (intel 14.0 works fine).
> > >>> Has anybody seen this before?
> > >>> Attaching configure.log
> > >>>
> > >>>
> > >>>
> > >>> I am using
> > >>> ./configure                           \
> > >>>    --download-exodusii=1             \
> > >>>    --download-chaco=1                \
> > >>>    --download-hdf5=1                 \
> > >>>    --download-metis=1                \
> > >>>    --download-netcdf=1               \
> > >>>    --download-parmetis=1             \
> > >>>    --download-sowing=1               \
> > >>>    --download-triangle=1             \
> > >>>    --download-yaml=1                 \
> > >>>    --with-cmake=cmake                \
> > >>>    --with-debugging=1                \
> > >>>    --with-gnu-compilers=1            \
> > >>>    --with-mpi-dir=$MPI_HOME          \
> > >>>    --with-pic                        \
> > >>>    --with-shared-libraries=1         \
> > >>>    --with-x11=1
> > >>>
> > >>> gcc is from Xcode 5.0.1, and gfortran from home-brew
> > >>> bourdin@galerkin:conf (master)$ gcc --version
> > >>> Configured with: 
> > >>> --prefix=/Applications/Xcode.app/Contents/Developer/usr 
> > >>> --with-gxx-include-dir=/usr/include/c++/4.2.1
> > >>> Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
> > >>> Target: x86_64-apple-darwin13.0.0
> > >>> Thread model: posix
> > >>> bourdin@galerkin:conf (master)$ gfortran --version
> > >>> GNU Fortran (GCC) 4.8.2
> > >>>
> > >>> Any idea?
> > >>>
> > >>> Blaise
> > >>>
> > >>> --
> > >>> Department of Mathematics and Center for Computation & Technology
> > >>> Louisiana State University, Baton Rouge, LA 70803, USA
> > >>> Tel. +1 (225) 578 1612, Fax  +1 (225) 578 4276 
> > >>> http://www.math.lsu.edu/~bourdin
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> <configure.log.gz>
> > >>
> > >>
> > >
> > >
> >
> >
> 
> 
Russ Rew                                         UCAR Unidata Program
address@hidden                      http://www.unidata.ucar.edu



Ticket Details
===================
Ticket ID: HVY-215335
Department: Support netCDF
Priority: Normal
Status: Closed