[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[LDM #GOY-305854]: ldmd exit behavior

Bryan,

It's a little more complicated than your patch, but you absolutely right: the 
top-level LDM server should exit with an error status if it does so because a 
child process crashed.

The equivalent of your patch will be in the next release.

> We encountered a very rare situation a few days ago where a child of the
> ldmd main process died with a segfault.  (We aren't sure why the child
> died, but that's not the purpose of this missive.  We are not planning on
> investigating that failure further since it happened with an older ldm
> version.)
> 
> We noticed that when a child dies and the process group leader notices
> that and shuts everything down, the leader exits with status 0.  On our
> debian servers, we have wrapped ldmd into a systemd service.  And if this
> very rare case happens, we would like to notice that the service has
> failed, but the 0 exit code prevents that.  I /think/ a non-zero exit code
> is appropriate for this case even when not using systemd.
> 
> I have applied a small patch (see attachment) to ldmd.c that makes ldmd
> exit with status 1 in the case of failed children, and am wondering if you
> are interested in incorporating it or something like it in a future
> release.
> 
> I am unsure if the behavior is correct for all use cases, as I can only do
> limited testing with our infrastructure.  I am also unsure if the style is
> right, etc.  The patch is applied against the latest version (6.13.2).
> 
> Thank you for considering this.

Thank *you* for sending this in.


Regards,
Steve Emmerson

Ticket Details
===================
Ticket ID: GOY-305854
Department: Support LDM
Priority: Normal
Status: Closed
===================
NOTE: All email exchanges with Unidata User Support are recorded in the Unidata 
inquiry tracking system and then made publicly available through the web.  If 
you do not want to have your interactions made available in this way, you must 
let us know in each email you send to us.