[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[IDV #JPX-323608]: WorldWind locations no longer work

> why don't you roll back your changes and I'll check mine in.
> 
> Don
> 

Ok, it is done.


Yuan
> On 7/17/14, 4:40 PM, Unidata IDV Support wrote:
> >> I'll have to do it tomorrow because now I have conflicts.  I think it
> >> would be better to back out of my changes because the Rectangle2D that
> >> you get from NavigatedDisplay.getLatLonBox() is wrong and will just
> >> create problems down the line.  I haven't seen any problems with the PR
> >> with the new changes I made.
> >>
> >> Don
> >>
> >
> > Ok, let me know and I can roll back my changes.
> >
> > Yuan
> >> On 7/17/14, 4:11 PM, Unidata IDV Support wrote:
> >>>> I'm not sure it's worth the effort.  Everything worked before the old
> >>>> way.  I just never should have made the change.  Your call though.
> >>>>
> >>>> Don
> >>>>
> >>>
> >>> I checked in the changes, more isolated to the worldwind classes. Could 
> >>> you give it a try?
> >>>
> >>>
> >>> Yuan
> >>>> On 7/17/14, 1:57 PM, Unidata IDV Support wrote:
> >>>>>> Yuan-
> >>>>>>
> >>>>>> I have a solution, which involves backing out of most of that checkin.
> >>>>>> My thought process on changing the NavigatedDisplay code was wrong.
> >>>>>> When we use a Rectangle2D for a lat/lon bounding box, we have to use 
> >>>>>> the
> >>>>>> convention that it is upside down from the way a Rectangle2D is 
> >>>>>> supposed
> >>>>>> to be where we have the origin at the lower left corner instead of the
> >>>>>> upper left. I tried to change it to be the upper left with that 
> >>>>>> checkin,
> >>>>>> but that logic is faulty and it doesn't seem like Rectangle2D likes
> >>>>>> negative widths.  This should probably all use LatLonRect instead of
> >>>>>> Rectangle2D, but I'm not going to do that change.
> >>>>>>
> >>>>>
> >>>>> I more prefer the LatLonRect option, and let me give it a try.
> >>>>>
> >>>>> Yuan
> >>>>>> This might have ripple effects on the progressive resolution stuff. 
> >>>>>> I've
> >>>>>> done some testing and didn't see any problems, but I didn't do an
> >>>>>> exhaustive test. Do you want me to check it in?
> >>>>>>
> >>>>>> Don
> >>>>>>
> >>>>>> On 7/17/14, 10:13 AM, Unidata IDV Support wrote:
> >>>>>>>> Full Name: Don Murray
> >>>>>>>> Email Address: address@hidden
> >>>>>>>> Organization: CU/CIRES
> >>>>>>>> Package Version: 5.0 build date:2014-06-01 23:09 UTC
> >>>>>>>> Operating System: Mac OS X
> >>>>>>>> Hardware: Java: home: 
> >>>>>>>> /Volumes/User/dmurray/IDV_5.0/jre.bundle/Contents/Home version: 
> >>>>>>>> 1.7.0_51 j3d:1.6.0-pre9-daily-experimental daily
> >>>>>>>> Description of problem: I think this probably is because of the 
> >>>>>>>> changes on conan, but no locations show up for the 
> >>>>>>>> Displays->Special->WorldWind locations.
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Don,
> >>>>>>>           The committed from 
> >>>>>>> https://github.com/Unidata/IDV/commit/452a3c7 broke the WorkdWind, do 
> >>>>>>> you have the time to take a look?
> >>>>>>>
> >>>>>>>
> >>>>>>> Yuan
> >>>>>>>
> >>>>>>> Ticket Details
> >>>>>>> ===================
> >>>>>>> Ticket ID: JPX-323608
> >>>>>>> Department: Support IDV
> >>>>>>> Priority: Normal
> >>>>>>> Status: Open
> >>>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Don Murray
> >>>>>> NOAA/ESRL/PSD and CU-CIRES
> >>>>>> 303-497-3596
> >>>>>> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> Ticket Details
> >>>>> ===================
> >>>>> Ticket ID: JPX-323608
> >>>>> Department: Support IDV
> >>>>> Priority: Normal
> >>>>> Status: Open
> >>>>>
> >>>>
> >>>> --
> >>>> Don Murray
> >>>> NOAA/ESRL/PSD and CU-CIRES
> >>>> 303-497-3596
> >>>> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>>>
> >>>>
> >>>
> >>>
> >>> Ticket Details
> >>> ===================
> >>> Ticket ID: JPX-323608
> >>> Department: Support IDV
> >>> Priority: Normal
> >>> Status: Open
> >>>
> >>
> >> --
> >> Don Murray
> >> NOAA/ESRL/PSD and CU-CIRES
> >> 303-497-3596
> >> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>
> >>
> >> I'll have to do it tomorrow because now I have conflicts.  I think it
> >> would be better to back out of my changes because the Rectangle2D that
> >> you get from NavigatedDisplay.getLatLonBox() is wrong and will just
> >> create problems down the line.  I haven't seen any problems with the PR
> >> with the new changes I made.
> >>
> >> Don
> >>
> >> On 7/17/14, 4:11 PM, Unidata IDV Support wrote:
> >>>> I'm not sure it's worth the effort.  Everything worked before the old
> >>>> way.  I just never should have made the change.  Your call though.
> >>>>
> >>>> Don
> >>>>
> >>>
> >>> I checked in the changes, more isolated to the worldwind classes. Could 
> >>> you give it a try?
> >>>
> >>>
> >>> Yuan
> >>>> On 7/17/14, 1:57 PM, Unidata IDV Support wrote:
> >>>>>> Yuan-
> >>>>>>
> >>>>>> I have a solution, which involves backing out of most of that checkin.
> >>>>>> My thought process on changing the NavigatedDisplay code was wrong.
> >>>>>> When we use a Rectangle2D for a lat/lon bounding box, we have to use 
> >>>>>> the
> >>>>>> convention that it is upside down from the way a Rectangle2D is 
> >>>>>> supposed
> >>>>>> to be where we have the origin at the lower left corner instead of the
> >>>>>> upper left. I tried to change it to be the upper left with that 
> >>>>>> checkin,
> >>>>>> but that logic is faulty and it doesn't seem like Rectangle2D likes
> >>>>>> negative widths.  This should probably all use LatLonRect instead of
> >>>>>> Rectangle2D, but I'm not going to do that change.
> >>>>>>
> >>>>>
> >>>>> I more prefer the LatLonRect option, and let me give it a try.
> >>>>>
> >>>>> Yuan
> >>>>>> This might have ripple effects on the progressive resolution stuff. 
> >>>>>> I've
> >>>>>> done some testing and didn't see any problems, but I didn't do an
> >>>>>> exhaustive test. Do you want me to check it in?
> >>>>>>
> >>>>>> Don
> >>>>>>
> >>>>>> On 7/17/14, 10:13 AM, Unidata IDV Support wrote:
> >>>>>>>> Full Name: Don Murray
> >>>>>>>> Email Address: address@hidden
> >>>>>>>> Organization: CU/CIRES
> >>>>>>>> Package Version: 5.0 build date:2014-06-01 23:09 UTC
> >>>>>>>> Operating System: Mac OS X
> >>>>>>>> Hardware: Java: home: 
> >>>>>>>> /Volumes/User/dmurray/IDV_5.0/jre.bundle/Contents/Home version: 
> >>>>>>>> 1.7.0_51 j3d:1.6.0-pre9-daily-experimental daily
> >>>>>>>> Description of problem: I think this probably is because of the 
> >>>>>>>> changes on conan, but no locations show up for the 
> >>>>>>>> Displays->Special->WorldWind locations.
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Don,
> >>>>>>>           The committed from 
> >>>>>>> https://github.com/Unidata/IDV/commit/452a3c7 broke the WorkdWind, do 
> >>>>>>> you have the time to take a look?
> >>>>>>>
> >>>>>>>
> >>>>>>> Yuan
> >>>>>>>
> >>>>>>> Ticket Details
> >>>>>>> ===================
> >>>>>>> Ticket ID: JPX-323608
> >>>>>>> Department: Support IDV
> >>>>>>> Priority: Normal
> >>>>>>> Status: Open
> >>>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Don Murray
> >>>>>> NOAA/ESRL/PSD and CU-CIRES
> >>>>>> 303-497-3596
> >>>>>> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> Ticket Details
> >>>>> ===================
> >>>>> Ticket ID: JPX-323608
> >>>>> Department: Support IDV
> >>>>> Priority: Normal
> >>>>> Status: Open
> >>>>>
> >>>>
> >>>> --
> >>>> Don Murray
> >>>> NOAA/ESRL/PSD and CU-CIRES
> >>>> 303-497-3596
> >>>> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>>>
> >>>>
> >>>
> >>>
> >>> Ticket Details
> >>> ===================
> >>> Ticket ID: JPX-323608
> >>> Department: Support IDV
> >>> Priority: Normal
> >>> Status: Open
> >>>
> >>
> >> --
> >> Don Murray
> >> NOAA/ESRL/PSD and CU-CIRES
> >> 303-497-3596
> >> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>
> >>
> >
> >
> > Ticket Details
> > ===================
> > Ticket ID: JPX-323608
> > Department: Support IDV
> > Priority: Normal
> > Status: Open
> >
> 
> --
> Don Murray
> NOAA/ESRL/PSD and CU-CIRES
> 303-497-3596
> http://www.esrl.noaa.gov/psd/people/don.murray/
> 
> 


Ticket Details
===================
Ticket ID: JPX-323608
Department: Support IDV
Priority: Normal
Status: Open